Skip to content

Fix ordering of erofs images in overlay fs#162

Merged
slp merged 1 commit intoAsahiLinux:mainfrom
teohhanhui:fix/overlay-lowerdir-order
Mar 28, 2025
Merged

Fix ordering of erofs images in overlay fs#162
slp merged 1 commit intoAsahiLinux:mainfrom
teohhanhui:fix/overlay-lowerdir-order

Conversation

@teohhanhui
Copy link
Copy Markdown
Collaborator

@teohhanhui teohhanhui commented Mar 28, 2025 •
edited
Loading

Otherwise we get fun stuff like:

overlay on /run/fex-emu/rootfs type overlay (ro,relatime,lowerdir=/run/fex-emu/vda:/run/fex-emu/vdb:/run/fex-emu/vdc,redirect_dir=on)

-> which means there's no /run/fex-emu/rootfs/lib{,64}/dri/{apple,asahi}_dri.so when running on Fedora Asahi Remix 42 beta

-> which causes Steam to fail to launch with error messages such as:

[2025-03-28 01:18:26] glx: failed to create dri3 screen
[2025-03-28 01:18:26] failed to load driver: asahi
[2025-03-28 01:18:26] 03/28 01:18:26 Failed writing minidump, nothing to upload.
[2025-03-28 01:18:26] /home/teohhanhui/.local/share/Steam/steam.sh: line 949:   381 Segmentation fault      "$STEAMROOT/$STEAMEXEPATH" "$@"

alyssarosenzweig
alyssarosenzweig approved these changes Mar 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@alyssarosenzweig alyssarosenzweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Youch. Thanks.

slp
slp approved these changes Mar 28, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@slp slp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@slp slp merged commit 9d035bc into AsahiLinux:main Mar 28, 2025
2 checks passed
@teohhanhui teohhanhui deleted the fix/overlay-lowerdir-order branch March 28, 2025 19:01
@garethwebber
Copy link
Copy Markdown

garethwebber commented Apr 12, 2025

Does a new release tag still need to be generated for this to get into Fedora 42?

@teohhanhui
Copy link
Copy Markdown
Collaborator Author

teohhanhui commented Apr 12, 2025

@garethwebber It was backported and released.

@jannau
Copy link
Copy Markdown
Member

jannau commented Apr 13, 2025 •
edited
Loading

The backport in muvm-0.3.1-3.fc42.aarch64 has not solved this issue. I still see the same issue as in the initial description.
Seems to be an issue with the backport it works as expected with 62d1be1 build from source.

@teohhanhui
Copy link
Copy Markdown
Collaborator Author

teohhanhui commented Apr 13, 2025

@slp WDYT about tagging a new release?

@WhatAmISupposedToPutHere
Copy link
Copy Markdown
Member

WhatAmISupposedToPutHere commented Apr 13, 2025

+1 on cutting a new release, the dhcp changes are a great ux improvement and should also be rolled out.

@jannau
Copy link
Copy Markdown
Member

jannau commented Apr 13, 2025

issue went away after reinstalling muvm-0:0.3.1-3.fc42.aarch64. If anything a downstream fedora issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slp slp slp approved these changes

@alyssarosenzweig alyssarosenzweig alyssarosenzweig approved these changes

@WhatAmISupposedToPutHere WhatAmISupposedToPutHere Awaiting requested review from WhatAmISupposedToPutHere WhatAmISupposedToPutHere is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@teohhanhui @garethwebber @jannau @WhatAmISupposedToPutHere @slp @alyssarosenzweig